addressing review comment

appsmithorg · Nov 27, 2024 · 0896ffb · 0896ffb
1 parent 45fed29
commit 0896ffb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/app/client/src/IDE/Components/FileTab/FileTab.tsx b/app/client/src/IDE/Components/FileTab/FileTab.tsx
@@ -25,12 +25,10 @@ export const FileTab = ({
   onDoubleClick,
   title,
 }: FileTabProps) => {
-  const identifier = `t--ide-tab-${sanitizeString(title)}`;
-
   return (
     <Styled.Tab
-      className={clsx("editor-tab", isActive && "active", identifier)}
-      data-testid={identifier}
+      className={clsx("editor-tab", isActive && "active")}
+      data-testid={`t--ide-tab-${sanitizeString(title)}`}
       onClick={onClick}
       onDoubleClick={onDoubleClick}
     >

diff --git a/app/client/src/IDE/Components/FileTab/styles.tsx b/app/client/src/IDE/Components/FileTab/styles.tsx
@@ -20,6 +20,7 @@ export const Tab = styled.div`
   border-left: 1px solid transparent;
   border-right: 1px solid transparent;
   border-top: 2px solid transparent;
+  flex-shrink: 0;
 
   &.active {
     background: var(--ads-v2-colors-control-field-default-bg);
@@ -38,11 +39,6 @@ export const Tab = styled.div`
   &.active > .tab-close {
     visibility: visible;
   }
-
-  &.t--ide-tab-new_query,
-  &.t--ide-tab-new_js {
-    flex-shrink: 0;
-  }
 `;
 
 export const IconContainer = styled.div`