Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example app for Sinatra sanitized routes #124

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

tombruijn
Copy link
Member

Add test route to Sinatra app to test the sanitized routes / route definition to be set as the path metadata to avoid storing PII and other sensitive data.

Related PR appsignal/appsignal-ruby#972

Copy link
Contributor

@unflxw unflxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the future, we should probably make it so a parameterised route is a requirement on the tests as well. I've been adding them to new test setups, it's useful to see that routes are anonymised correctly and how.

@tombruijn
Copy link
Member Author

In the future, we should probably make it so a parameterised route is a requirement on the tests as well. I've been adding them to new test setups, it's useful to see that routes are anonymised correctly and how.

Only way to make it required is by adding a test I think. You want to add tests for it?

@tombruijn
Copy link
Member Author

I've updated the config to use the filter_metadata config option added in appsignal/appsignal-ruby#973.

@backlog-helper
Copy link


This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

Add test route to Sinatra app to test the sanitized routes / route
definition to be set as the `path` metadata to avoid storing PII and
other sensitive data.

Related PR appsignal/appsignal-ruby#972
Added in PR appsignal/appsignal-ruby#973 in
favor of the `sinatra_sanitized_routes` option.
@tombruijn tombruijn force-pushed the sinatra-sanitized-routes branch from f9ffc83 to a10be05 Compare June 28, 2023 08:46
@tombruijn tombruijn merged commit 3574615 into main Jun 28, 2023
@tombruijn tombruijn deleted the sinatra-sanitized-routes branch June 28, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants