Check Rails.backtrace_cleaner method exists #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the Rails.backtrace_cleaner method exists before calling it. We've got a report from a user that the method call fails with a NoMethodError in a Sinatra app using the activesupport and actionmailer gems version 5.2.0. ``` NoMethodError - undefined method `backtrace_cleaner' for Rails:Module: /gems/appsignal-3.0.6/lib/appsignal/transaction.rb:530:in `cleaned_backtrace' ``` I was unable to reproduce in the test setups, but I can see a scenario where this could fail. To make sure we don't cause this kind of error in such a scenario, check if the Rails module listens to the `backtrace_cleaner` method before calling it. appsignal/test-setups@d484b36
jeffkreeftmeijer
approved these changes
Jun 23, 2021
|
While performing the daily checks some issues were found with this Pull Request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the Rails.backtrace_cleaner method exists before calling it.
We've got a report from a user that the method call fails with a
NoMethodError in a Sinatra app using the activesupport and actionmailer
gems version 5.2.0.
I was unable to reproduce in the test setups, but I can see a scenario
where this could fail. To make sure we don't cause this kind of error in
such a scenario, check if the Rails module listens to the
backtrace_cleanermethod before calling it.appsignal/test-setups@d484b36