Add Ruby config file option to installer #1327
Conversation
tombruijn
force-pushed
the
config-rb-file
branch
from
febcc56 to
59f8283
Compare
Differentiate between YAML install method and others in the matcher names so it's easier to add ones for the Ruby config file later.
To replace the YAML config file people need to know they can configure the gem with a Ruby config file too. Add this option to the installer so people can choose this config option when installing AppSignal in their application. I've made it the first listed method as it's the most flexible configuration method. The YAML file option has the "legacy" label next to it now to discourage people from using it.
tombruijn
force-pushed
the
config-rb-install
branch
from
944dfcf to
0d2e2bd
Compare
There was a problem hiding this comment.
The YAML file option has the "legacy" label next to it now to discourage people from using it.
Could/should we remove it entirely? 🤔 The installer is mostly used by new AppSignal users, I don't think they'll miss it.
Either way, now that the YAML is considered legacy, are there things that need to be changed regarding how we document configuration options? Perhaps the order of the code snippets and sections in the configuration overview page should be changed to put .rb first.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This is a message from the daily scheduled checks. |
I don't want to shock and confuse existing customers that are used to configure with the YAML file and don't have the time to adapt to the new thing right away. So I don't want to introduce a new thing and take out the old way in the same version. It's legacy now and we can choose to remove it in a version before the next major version.
Yes, we should update the docs to make the |
Remove the list of errors that isn't needed to include all. Link to the docs of the options listed.
Based on #1324
Rename matchers in installer spec
Differentiate between YAML install method and others in the matcher names so it's easier to add ones for the Ruby config file later.
Add Ruby config file option to installer
To replace the YAML config file people need to know they can configure the gem with a Ruby config file too. Add this option to the installer so people can choose this config option when installing AppSignal in their application.
I've made it the first listed method as it's the most flexible configuration method. The YAML file option has the "legacy" label next to it now to discourage people from using it.