Do not report SystemExit errors in at_exit handler #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SystemExit can be a normal shutdown or a shutdown by the host. We do not need to report those normal events. If people do want to report this error they can add their own `at_exit` handler, but let's not report it by default.
jeffkreeftmeijer
approved these changes
Aug 23, 2024
tombruijn
added a commit
that referenced
this pull request
Jan 10, 2025
Same as for our `at_exit` hook in PR #1257, do not report SystemExit errors for Rake. These are raised by explicitly calling `exit` in apps, and it's unlikely people want to be reported all the time about them. Closes appsignal/support#349
tombruijn
added a commit
that referenced
this pull request
Jan 10, 2025
Same as for our `at_exit` hook in PR #1257, do not report SystemExit errors for Rake. These are raised by explicitly calling `exit` in apps, and it's unlikely people want to be reported all the time about them. Closes appsignal/support#349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SystemExit can be a normal shutdown or a shutdown by the host. We do not need to report those normal events.
If people do want to report this error they can add their own
at_exithandler, but let's not report it by default.