Deprecate Appsignal.listen_for_error helper #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, remove the `listen_for_error` helper. It doesn't allow for as much customization as `report_error` does. We're not going to add a ton of arguments to `listen_for_error` to allow all kinds of metadata to be set that way. Instead, let's remove it in the next version. https://appsignal.slack.com/archives/C07BBHJCNP9/p1722354302496879
tombruijn
added a commit
that referenced
this pull request
Aug 5, 2024
This was deprecated in PR #1229, we can remove it in the next major version.
tombruijn
added a commit
that referenced
this pull request
Aug 5, 2024
This was deprecated in PR #1229, we can remove it in the next major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, remove the
listen_for_errorhelper. It doesn't allow for as much customization asreport_errordoes. We're not going to add a ton of arguments tolisten_for_errorto allow all kinds of metadata to be set that way. Instead, let's remove it in the next version.https://appsignal.slack.com/archives/C07BBHJCNP9/p1722354302496879