-
Notifications
You must be signed in to change notification settings - Fork 116
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ActiveSupport Logger broadcast compatibility
We were using `progname` instead of group in the AppSignal Logger `add` method. Making the convenience methods such as `warn`, `info`, etc. Not logging anything when called as in: ```ruby Rails.logger.warn("Warning message") ``` This commits updates that to use `group` instead of `progname` as in the original Ruby Logger implementation. Co-authored-by: Jörg Schiller <[email protected]>
- Loading branch information
1 parent
05dc9fe
commit 1750072
Showing
3 changed files
with
15 additions
and
4 deletions.
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
.changesets/fix-activesupport-logger-broadcast-compatibility.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
bump: "patch" | ||
type: "fix" | ||
--- | ||
|
||
Fixed a bug that prevented log messages from getting to AppSignal when using the convenience methods as in: | ||
|
||
```ruby | ||
Rails.logger.warn("Warning message") | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters