Skip to content

Commit

Permalink
Pass build platforms in environment variable
Browse files Browse the repository at this point in the history
On my Intel machine, the ARM build gets stuck on building the final
artifact, using 100% CPU and slowly increasing memory use forever.

I will look into sorting this out, but for now, being able to pass
`PLATFORMS=linux/amd64` provides a workaround for testing it locally.

I have also made `TAG` into an environment variable as that allows
for builds to be given different tags -- this makes it easier to
check that your local Kubernetes isn't running a stale build.
  • Loading branch information
unflxw committed Oct 1, 2024
1 parent 7bc9096 commit be3cdac
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
TAG=$(shell git describe --tags --abbrev=0 | tr -d v)
TAG ?= $(shell git describe --tags --abbrev=0 | tr -d v)
PLATFORMS ?= "linux/amd64,linux/arm64"

.PHONY: build push setup

build:
docker buildx build \
--platform linux/amd64,linux/arm64 \
--platform $(PLATFORMS) \
--builder=appsignal-container \
--load \
--tag appsignal/appsignal-kubernetes:$(TAG) \
Expand Down

0 comments on commit be3cdac

Please sign in to comment.