Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw AssertionError instead of Error in case of approval failure #595

Closed
wants to merge 1 commit into from
Closed

Throw AssertionError instead of Error in case of approval failure #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion approvaltests/src/main/java/org/approvaltests/Approvals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ private static void verifyEachFileAgainstMasterDirectory(File[] files, Options o
if (!mismatched.isEmpty())
{
String message = "The Following Files did not match up: " + getFileNameList(mismatched);
throw new Error(message);
throw new AssertionError(message);
}
}
private static String getFileNameList(List<File> mismatched)
Expand Down
2 changes: 1 addition & 1 deletion approvaltests/src/main/java/org/approvaltests/approvers/FileApprover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public VerifyResult reportFailure(ApprovalFailureReporter reporter)
}
public void fail()
{
throw new Error(String.format("Failed Approval\n Approved:%s\n Received:%s", approved.getAbsolutePath(),
throw new AssertionError(String.format("Failed Approval\n Approved:%s\n Received:%s", approved.getAbsolutePath(),
received.getAbsolutePath()));
}
public static VerifyResult approveTextFile(File received, File approved)
Expand Down