Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console logs except error logging #158

Merged

Conversation

neelvirdy
Copy link
Contributor

Removes non-error console logs since React advises to minimize console.log calls.

https://reactnative.dev/docs/performance/#using-consolelog-statements

re-add error logging and clean some whitespaces

Re-add error logging

Re-add more error logs

log errors in crypto
@neelvirdy neelvirdy requested a review from kelindi January 9, 2023 20:13
@jimmylee
Copy link
Contributor

New conflicts on this PR

Copy link
Contributor

@jimmylee jimmylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmylee jimmylee merged commit 525956b into application-research:master Jan 13, 2023
APiligrim pushed a commit that referenced this pull request Jan 18, 2023
Remove console logs except error logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants