Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added converters for Unity.Mathematics. This includes all the
float2
,double3
,int4
,bool4
, and similar types. (#80)There are no custom converters for the matrix types (
float2x2
,float2x3
, etc), as they currently work out-of-the-box.Added
ResolutionConverter
to be able to read JSON from older Unity versions. (#79)Fixed compilation errors when targeting .NET Standard 2.1. (#79)
Fixed converter types taking long time to load, sometimes causing lag spikes each time assembly got reloaded (especially when entering play-mode).
The issue was that this package tries to find all converters by looping through all types in all assemblies.
You should see better performance now, as we are using more optimized code paths and making use of Unity's TypeCache.
If your project still suffers from big lag spikes, then you can opt-out completely of the "auto type scanning" code via the settings found at "Edit > Json.NET converters settings..." (#79)