Removed __makeref usage for IL2CPP #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
added a commit
that referenced
this pull request
Jul 15, 2020
applejag
added a commit
that referenced
this pull request
Jul 15, 2020
* Added basic scriptableobject tests * Added more tests * Removed ScriptableObjectConverter * Added custom ContractResolver * Removed error catching * Moved method to TypeTesterBase * Added test to verify issue #38 * Added scriptableobject to compatability table * Updated README.md with ScriptableObject note * Applied codecop fixes * Updated README & CHANGELOG * Added missing changelog note from #35 * Added yet another sonar warning disabling * Updated version to v1.1.0-preview.1 and enabled live run
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IL2CPP doesn't handle setting fields via
TypedReference, so I changed to use the boxing variant.Keeping the TypedReference for non-IL2CPP builds though as it's faster and doesn't allocate any heap.
Uses the
ENABLE_IL2CPPplatform define directive to filter on IL2CPP builds.Fixes #34