Swift5.0: Change Data(bytes:) to Data(_:) #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, an assignment such as:
var f: Float
f = 1e-50
is an implicit conversion from a Double literal to a Float.
Swift 5 now warns when such conversions lose precision.
To suppress these, I've added explicit conversions to obtain:
f = Float(1e-50)
Swift 5 has deprecated an old Data initializer. Fortunately, the recommended form works back to Swift 4, so we don't have to introduce any `#if swift` conditionals.
… swift50-data-init
|
With this, the only remaining Swift 5.0 issue is an API change for |
tbkka
changed the title
|
Testing: I just verified (on Ubuntu 16.04) that this builds and passes the test suite using Swift 4.0, 4.0.2, 4.0.3, 4.1.2, 4.2.3, and the 5.0 snapshot from March 10. |
We likely also need to look at some of the JSON/TextFormat stuff because of the |
thomasvl
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty simple global substitution to stop using the deprecated
Data(byte:)initializer.The recommended alternative
Data(_:)works with Swift 4 and later, so we don't need any compiler conditionals; we can just change the code.Note: I've not tested the performance impacts; I believe the
Data(byte:)initializer was faster at one time. Hopefully that's been addressed.