Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4.2 is the current GM, so our min is 3.2. #825

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Swift 4.2 is the current GM, so our min is 3.2. #825

merged 1 commit into from
Jan 4, 2019

Conversation

thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Jan 4, 2019

  • Update docs.
  • Remove all #if swift(>=3.2) checks dropping the else clause.

@thomasvl
Swift 4.2 is the current GM, so our min is 3.2.
828921a 
- Update docs.
- Remove all `#if swift(>=3.2)` checks dropping the `else` clause.
@thomasvl thomasvl requested review from tbkka and allevato January 4, 2019 17:13
tbkka
tbkka approved these changes Jan 4, 2019
View reviewed changes
Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! \o/

@thomasvl thomasvl merged commit 3088a28 into apple:master Jan 4, 2019
@thomasvl thomasvl deleted the min_swift_3_2 branch January 4, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@allevato allevato Awaiting requested review from allevato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasvl @tbkka