-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CocoaPods support #5
Conversation
My 2c:
My opinion is |
Okay, I added I'd still suggest considering options (2) and (3), but the PR is mergeable as it is ;) |
@jcanizales : The generated files in the runtime library are in fact edited to remove the import statements. See https://github.com/apple/swift-protobuf-runtime/blob/master/Makefile#L95 |
I'll see about renaming the module to "SwiftProtobuf". That will be a little disruptive in the short-term, but seems the best long-term fix. I'd like to do that before we merge this, if that's okay. I'll get to it soon. |
I just committed the name change; the module is now called 'SwiftProtobuf'. Please update your merge request accordingly and I'll merge it. Thanks! |
Thank you — 'SwiftProtobuf' makes a ton of sense! I updated the Podspec and Readme — should be good to merge! |
I've merged this, but we may need to update it after Issue #8 gets finished. |
This resolves #1.
There's just one problem before this can just work: I named the Pod "SwiftProtobufRuntime", but the generated
.pb.swift
files doimport Protobuf
— they think this library should be called just "Protobuf".There's a few possible solutions:
swift-protobuf-plugin
to customize the generated import, so people using CocoaPods or already using Protobuf in their apps (with other libraries) could resolve the naming conflictProtobufSwift
orProtobufRuntime
for everyone.WDYT?