Let CodeGenerators provide extension for CustomOptions. #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjcairo how's this look for your use case? |
gjcairo
reviewed
Jul 16, 2024
|
Thanks @thomasvl ! Other than the comment about the missing |
This will get those extensions recognized when the request from protoc is parsed, and then a generator can use the existing SwiftProtobuf extension related apis to access them. Fixes apple#1677
thomasvl
force-pushed
the
custom_option_parsing
branch
from
01b92f5 to
2222bbd
Compare
thomasvl
requested review from
gjcairo and
allevato
and removed request for
gjcairo
allevato
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get those extensions recognized when the request from protoc is parsed, and then a generator can use the existing SwiftProtobuf extension related apis to access them.
Fixes #1677