Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the old init signatures. #1023

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Add back the old init signatures. #1023

merged 1 commit into from
Jul 9, 2020

Conversation

thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Jul 9, 2020

Fixes #1022.

@thomasvl thomasvl requested a review from tbkka July 9, 2020 12:52
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jul 9, 2020

@Lukasa fyi

Lukasa
Lukasa approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, looks perfect, thanks @thomasvl!

@thomasvl thomasvl merged commit a4ba9e5 into apple:master Jul 9, 2020
@thomasvl thomasvl deleted the addback_inits branch July 9, 2020 13:13
@Lukasa Lukasa mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@tbkka tbkka Awaiting requested review from tbkka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API-breaking change in #1002
2 participants
@thomasvl @Lukasa