Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Decoder performance #251

Closed
tbkka opened this issue Feb 13, 2017 · 1 comment
Closed

Text Decoder performance #251

tbkka opened this issue Feb 13, 2017 · 1 comment

Comments

@tbkka
Copy link
Collaborator

tbkka commented Feb 13, 2017

The Text decoder could be a lot faster. The slowness is not inherently due to the generated API, since the JSON decoder is now acceptably fast.

Idea #1: It might suffice to change the Text decoder to work against the UTF16View instead of the UTF8View. Strings are UTF-16 internally, so the iterators and accessors for that form should be faster.

Idea #2: If the above is insufficient, the Text decoder could be overhauled to use the same binary decoding approach currently used by the JSON decoder.

Note: This is not a blocking issue for 1.0
@tbkka
Copy link
Collaborator Author

tbkka commented Apr 17, 2017

This was addressed a while back by reworking the Text decoder to use the binary decoding approach.

@tbkka tbkka closed this as completed Apr 17, 2017
ahmed-osama-saad pushed a commit to ahmed-osama-saad/swift-protobuf that referenced this issue Oct 12, 2023
@jalpedersen
ios: Queue up messages
fc331af 
Queue up messages until event-sink has been created
Closes apple#307, apple#251, apple#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbkka