Fix native tests in CircleCI #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where the CI job attempts to install the wrong executable when on macOS/aarch64. Also, adjusts native test definitions in pkl-server to match pkl-core.
pkl-server/pkl-server.gradle.kts
Outdated
| buildInfo.os.isMacOsX -> { | ||
| dependsOn(testMacExecutableAarch64) | ||
| if (buildInfo.arch == "aarch64") { | ||
| dependsOn(testMacExecutableAmd64) |
There was a problem hiding this comment.
We depend on amd64 if the arch is aarch64? I'm not following the logic here. Shouldn't this be done like linux with separate bodies for each architecture?
There was a problem hiding this comment.
Ah, this logic was flipped around. Will fix.
We cross-build when on macOS/aarch64, thanks to Rosetta. We can't do this on Linux, though.
stackoverflow
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the CI job attempts to install the wrong executable when on macOS/aarch64.
Also, adjusts native test definitions in pkl-server to match pkl-core.