Improve configuration of native image compilation #509
Conversation
| .withPathSensitivity(PathSensitivity.RELATIVE) | ||
| } | ||
|
|
||
| private fun Test.configureExecutableTest(engineName: String) { |
There was a problem hiding this comment.
Any reason why testWindowsExecutableAmd64 doesn't call this function, just mac and linux?
| } | ||
|
|
||
| private val transports: Pair<MessageTransport, MessageTransport> = run { | ||
| if (USE_DIRECT_TRANSPORT) { |
There was a problem hiding this comment.
This is always false, why have an if?
There was a problem hiding this comment.
This is just here to allow us to test the same logic if we wanted to run the server tests with an encoder/decoder. It's for development purposes. I'll add a note here.
- Solve msgpack issue with `--initialize-at-run-time`. - Use quick build mode for non-release builds: 40% faster compilation, 20% smaller executable. - Remove options that were commented out.
Motivation: - improve test coverage of server mode - verify that "--initialize-at-run-time=org.msgpack.core.buffer.DirectBufferAccess" works fine and opening JDK internals with "--add-opens" isn't required Changes: - split ServerTest into JvmServerTest and NativeServerTest - extract native executable paths to PklExecutablePaths
| companion object { | ||
| private const val USE_DIRECT_TRANSPORT = false | ||
| } |
There was a problem hiding this comment.
What are the reasons of using a companion object instead of a normal constant in that kt file?
There was a problem hiding this comment.
You mean, why not move this up to the file level? I tend to prefer this approach because it more easily translates to Java (you don't end up with a synthetic FooKt class).
There was a problem hiding this comment.
Yes exactly, that was my question 🙃.
But actually you end up with a Foo.Companion 🤷♂️ 😂
There was a problem hiding this comment.
Yeah, true. We already need the companion class, and we could mark them @JvmStatic to get around it. But, I think this would be splitting hairs a little bit.
This is supercedes and closes #455
Thanks to @translatenix for doing 99% of the work here
--add-opensby deferring initialization of MessagePack library at build time