Drop java 11, bump GraalVM to 23.0 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odenix
reviewed
Apr 18, 2024
pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeSuperMethodNode.java
Outdated
Show resolved
Hide resolved
holzensp
approved these changes
Apr 24, 2024
| @@ -38,7 +38,7 @@ jmh { | |||
| } | |||
|
|
|||
| tasks.named("jmh") { | |||
| dependsOn(":installGraalVm") | |||
| dependsOn(":installGraalVmAmd64") | |||
There was a problem hiding this comment.
Should we specialize the jmh task to ARM too?
There was a problem hiding this comment.
I think I'll leave this as a TODO. Would certainly be nice to have benchmarks for both architectures.
* Remove unnecessary strictfp modifier * Add annotations to address Truffle DSL warnings (@idempotent, @exclusive) * Adjust build logic to allow building cross-arch on macOS * Add warning suppression for specialization limit (left this one as a TODO)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I enabled build native jobs here because this PRB introduces changes there. I'm planning on getting rid of them again before merging.
A remaining TODO here is to tune our specialization limits (see commit for details)
After dropping Java 11, we can start using records, and also switch our Java code generators to use records.