Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue. #7095

Merged
merged 1 commit into from
May 6, 2022
Merged

Fix compatibility issue. #7095

merged 1 commit into from
May 6, 2022

Conversation

RenxuanW
Copy link
Contributor

@RenxuanW RenxuanW commented May 6, 2022

New added field should be the last in serializer.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

New added field should be the last in serializer.
@RenxuanW RenxuanW requested review from halfprice and jzhou77 May 6, 2022 19:26
Copy link
Contributor

@jzhou77 jzhou77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not needed, since the main is one major version ahead, thus reordering is fine. I'll leave it to you to decide.

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 05e9ff0
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@RenxuanW RenxuanW merged commit 14e5fc5 into apple:main May 6, 2022
@RenxuanW RenxuanW deleted the another branch May 6, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants