Skip to content

Commit

Permalink
Fix provisional GRV Proxy ID in GetReadVersionReply
Browse files Browse the repository at this point in the history
This was not set and can cause infinite loop in simulation where the client
calls getConsistentReadVersion(), in which we do "continue" for stale GRV reply
and retry. Then this repeats forever.
  • Loading branch information
jzhou77 committed Apr 13, 2022
1 parent 3fa1f81 commit c3c8511
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fdbserver/ClusterRecovery.actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,7 @@ ACTOR Future<Standalone<CommitTransactionRef>> provisionalMaster(Reference<Clust
rep.version = parent->lastEpochEnd;
rep.locked = locked;
rep.metadataVersion = metadataVersion;
rep.proxyId = parent->provisionalGrvProxies[0].id();
req.reply.send(rep);
} else
req.reply.send(Never()); // We can't perform causally consistent reads without recovering
Expand Down

0 comments on commit c3c8511

Please sign in to comment.