configure: improve interpreter detection #5122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the respective AC_DEFINE_UNQUOTED(CUPS_PHP) call, assigning anything to CUPS_PHP is a no-op. Remove it so the surrounding test looks like the other tests in the file. Signed-off-by: Roland Hieber <[email protected]>
Currently, when configure is called with --with-java or --with-java=, auto-detection is performed. When called with --without-java, HAVE_JAVA is still being defined. This is unfortunate when cross-compiling for embedded systems, we would end up with Java on the host being auto-detected (which is not what we have on the target), or with a wrong HAVE_JAVA define. We need a way to explicitely disable scripting support for all supported languages. Signed-off-by: Roland Hieber <[email protected]>
Signed-off-by: Roland Hieber <[email protected]>
|
Ultimately I think I want to eliminate all of the third-party scripting support - only Java "needs" special handing as the others support the #! interpreter mechanism... |
|
Ah ok, yes, that seems reasonable. Feel free to only pick the Java part from this PR. |
michaelrsweet
added a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when configure is called with
--with-javaor--with-java=, auto-detection is performed. When called with--without-java,HAVE_JAVAis still being defined. This is unfortunate when cross-compiling for embedded systems, we would end up with Java on the host being auto-detected (which is not what we have on the target), or with a wrongHAVE_JAVAdefine.This implements a way to explicitely disable scripting support for all supported languages with ``without-java` (or the respective options for Perl, PHP and Python)
While we're at it, make the detection a bit more verbose, and do some cleanup.