Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API: utils.evaluate_regressor and utils.evaluate_classifier #1572

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

TobyRoseman
Copy link
Collaborator

Don't assume source predictions are always stored (in the data frame) in a column called prediction. Instead, assume that column name matches the key in the dictionary returned by predict, similar to how we assume input keys to predict match other columns. This parameter value defaults to target.

This is an API breaking change.

Fixes #58

jakesabathia2
jakesabathia2 previously approved these changes Aug 9, 2022
Copy link
Collaborator

@jakesabathia2 jakesabathia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an old bug! :D
Nice fix!

@TobyRoseman
Copy link
Collaborator Author

@TobyRoseman
Copy link
Collaborator Author

@TobyRoseman TobyRoseman merged commit ec12f43 into apple:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coremltools.utils.evaluate_regressor requires target parameter only with 'prediction' value
2 participants