Fix the behaviour of autoLaunch capability #1026
Conversation
README.md
Outdated
| @@ -138,6 +138,7 @@ Differences are noted here: | |||
| |`useSimpleBuildTest`| Build with `build` and run test with `test` in xcodebuild for all Xcode version if this is `true`, or build with `build-for-testing` and run tests with `test-without-building` for over Xcode 8 if this is `false`. Defaults to `false`. | `true` or `false` | | |||
| |`wdaEventloopIdleDelay`|Delays the invocation of `-[XCUIApplicationProcess setEventLoopHasIdled:]` by the number of seconds specified with this capability. This can help quiescence apps that fail to do so for no obvious reason (and creating a session fails for that reason). This increases the time for session creation because `-[XCUIApplicationProcess setEventLoopHasIdled:]` is called multiple times. If you enable this capability start with at least `3` seconds and try increasing it, if creating the session still fails. Defaults to `0`. |e.g. `5`| | |||
| |`processArguments`|Process arguments and environment which will be sent to the WebDriverAgent server.|`{ args: ["a", "b", "c"] , env: { "a": "b", "c": "d" } }` or `'{"args": ["a", "b", "c"], "env": { "a": "b", "c": "d" }}'`| | |||
| |`autoLaunch`|Avoid the application under test to be automatically executed after new session startup if set to `false`. `true` by default.|`true` or `false`| | |||
There was a problem hiding this comment.
Suggest: When set to 'false', prevent the application under test from being installed and launched automatically as part of the new session startup process. Installation and launch become the responsibility of the user. Defaults to 'true'.
| @@ -1079,11 +1079,6 @@ class XCUITestDriver extends BaseDriver { | |||
| if (this.isSafari()) { | |||
| return; | |||
| } | |||
| // if user has passed in desiredCaps.autoLaunch = false | |||
| // meaning they will manage app install / launching | |||
| if (this.opts.autoLaunch === false) { | |||
There was a problem hiding this comment.
how does removing this code change the behavior to be correct?
There was a problem hiding this comment.
the name of the capability is autoLaunch, which means it should have nothing to do with app installation. Also, if one wants to avoid an app to be installed, then he could always only provide a bundle Id instead of an application path
There was a problem hiding this comment.
ah ok then my suggestion would need to be reworded to not mention installation i guess.
Please do not merge before appium/WebDriverAgent#195 is published