fix: Properly exclude attributes from snapshots to speed up xpath lookup #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
|
CC @sshock |
Oh nice. Will be interesting to see if this helps our performance. |
KazuCocoa
approved these changes
Oct 9, 2020
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- app/src/main/java/io/appium/uiautomator2/model/UiElementSnapshot.java 16
- app/src/main/java/io/appium/uiautomator2/utils/ElementLocationHelpers.java 1
See the complete overview on Codacy |
dpgraham
reviewed
Oct 9, 2020
| if (value != null) { | ||
| attribs.put(key, value); | ||
| } | ||
| } | ||
|
|
||
| private Map<Attribute, Object> collectAttributes(AccessibilityNodeInfo node, int index) { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only excluding redundant attributes from the xml itself, which did not affect the performance much, but now we also exclude them from snapshots. And it does the job