fix: minBrowserVersion in SyncOption should be a number #291
+59
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Mar 13, 2023
|
It looks like unit tests need some update |
|
Thank you for reviews, I'll take a look at CI not working too. |
|
I fixed the points according to your comments, PTAL |
| function convertToInt(value) { | ||
| switch (typeof value) { | ||
| case 'number': | ||
| return Number.isNaN(value) ? null : value; |
There was a problem hiding this comment.
this might also return floats, but that is probably not something we care much
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
## [5.3.1](v5.3.0...v5.3.1) (2023-03-16) ### Bug Fixes * install-npm.js fails to run npm run build due to type error ([#292](#292)) ([1e3014b](1e3014b)) * minBrowserVersion in SyncOption should be a number ([#291](#291)) ([39d8fdd](39d8fdd)) ### Miscellaneous Chores * ChromeDriver Bump to v111.0.5563.64 ([#290](#290)) ([2c4c144](2c4c144))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue to fix
This PR fixes an issue where selectMatchingDrivers() ignores
minBroswerVersionand attempts to download a lot of unnecessary ChromeDrviers.Here is a log. While it can detect the Chrome version, it doesn't filter with the minimum browser version.
Cause
selectMatchingDrivers() assumes
minBrowserVersionis a string but it's always a number as it's given here and the type ofSemver.chromeVersion.majoris number. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/semver/classes/semver.d.ts#L12