Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove amp-ui #676

Merged
merged 1 commit into from
Jan 11, 2017
Merged

remove amp-ui #676

merged 1 commit into from
Jan 11, 2017

Conversation

freignat91
Copy link
Contributor

related to #668

removing amp-ui from amp

test:
-amp pf stop
-amp pf pull: do not pull the amp-ui image
-amp pf start: do not start amp-ui anymore

with ampadm

  • amp pf stop
  • make TAG=local build-image
  • ampadm cluster start
  • ampadm pf pull --local: do not pull amp-ui
    -ampadm pf start --local: do not start amp-ui

subfuzion
subfuzion approved these changes Jan 11, 2017
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subfuzion subfuzion merged commit 921ebf5 into master Jan 11, 2017
subfuzion pushed a commit that referenced this pull request Jan 12, 2017
@freignat91 @subfuzion
remove amp-ui (#676)
b47181c
@subfuzion subfuzion mentioned this pull request Jan 12, 2017
Merged
generalhenry pushed a commit that referenced this pull request Jan 12, 2017
@subfuzion @generalhenry
[v0.6.x] Cherrypicks (#681)
9ab92a8 
* bump version to 0.6.0-dev

* Added amp help command (#652)

* Included Long message in help command output

* fix proto files compilation (#664)

* remove amp-ui (#676)
bquenin pushed a commit that referenced this pull request Jan 12, 2017
@subfuzion
[v0.6.x] Cherrypicks (#681)
e1a5307 
* bump version to 0.6.0-dev

* Added amp help command (#652)

* Included Long message in help command output

* fix proto files compilation (#664)

* remove amp-ui (#676)
@ndegory
Copy link
Contributor

ndegory commented Jan 12, 2017

@freignat91 I think we still have a mapping in haproxy for this service

@freignat91 freignat91 deleted the remove-amp-ui branch January 17, 2017 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @ndegory @subfuzion