-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #370
Comments
Do you mind if I submit a PR for renaming the test files from:
to
? |
I'd like them renamed, but there is no reason for them to be numbered sequentially, giving a false sense of them running in order (see discussion here: #374 (comment)). Just drop the numbers altogether. Also, let's get rid of "invalid". That was copied over from the stack file parse tests where it made sense to indicate that the stack file format was invalid. In addition to having support for expected output (which can be an error message just as much as it can be anything else), we should also support an expected exit code. It's not a bad idea to have a key for each test case that does indicated it is a negative ("unhappy") case test just so we can keep track and report in test results. cc/ @ndegory @bquenin @JosephGJ @neha-viswanathan @generalhenry |
IMO current status of CLI tests justifies that we close this PR (in time for 0.3.0) |
We made good progress on testing. This is an ongoing effort, so I'm going to update the milestone. |
We need to increase test coverage and extend integration tests to include networking, etc (see current integration tests here).
Work on removing any redundancy with current backend integration tests (ie, those that require starting amplifier), that can be defined by yaml test specs and added here.
The text was updated successfully, but these errors were encountered: