Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new integration to delete old unused AMIs #3528

Merged
merged 1 commit into from
May 26, 2023

Conversation

rporres
Copy link
Contributor

@rporres rporres commented May 23, 2023

@rporres rporres force-pushed the aws-ami-cleanup branch from 251d133 to 8cecb29 Compare May 24, 2023 09:48
@rporres
Copy link
Contributor Author

rporres commented May 24, 2023

This depends on #3529. See boto/boto3#1991 (comment).

@rporres rporres force-pushed the aws-ami-cleanup branch 3 times, most recently from f02add1 to eb1e7f7 Compare May 24, 2023 15:13
@rporres rporres changed the title Add new integration to delete unused AMIs Add new integration to delete old unused AMIs May 24, 2023
Copy link
Member

@chassing chassing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Ship it 🚀

Copy link
Contributor

@hemslo hemslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@rporres rporres force-pushed the aws-ami-cleanup branch from 47b58c5 to bed8506 Compare May 25, 2023 16:42
part of APPSRE-7272

design-doc in: docs/app-sre/design-docs/aws-ami-cleanup.md

Signed-off-by: Rafa Porres Molina <[email protected]>
@rporres rporres force-pushed the aws-ami-cleanup branch from bed8506 to 110f9bf Compare May 26, 2023 13:49
@rporres rporres merged commit ee3b8b0 into app-sre:master May 26, 2023
@rporres rporres deleted the aws-ami-cleanup branch May 26, 2023 14:04
bkez322 pushed a commit to bkez322/qontract-reconcile that referenced this pull request Jul 13, 2023
part of APPSRE-7272

design-doc in: docs/app-sre/design-docs/aws-ami-cleanup.md

Signed-off-by: Rafa Porres Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants