-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new integration to delete old unused AMIs #3528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on #3529. See boto/boto3#1991 (comment). |
rporres
commented
May 24, 2023
f02add1
to
eb1e7f7
Compare
hemslo
reviewed
May 25, 2023
chassing
requested changes
May 25, 2023
chassing
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Ship it 🚀
hemslo
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
part of APPSRE-7272 design-doc in: docs/app-sre/design-docs/aws-ami-cleanup.md Signed-off-by: Rafa Porres Molina <[email protected]>
bkez322
pushed a commit
to bkez322/qontract-reconcile
that referenced
this pull request
Jul 13, 2023
part of APPSRE-7272 design-doc in: docs/app-sre/design-docs/aws-ami-cleanup.md Signed-off-by: Rafa Porres Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of APPSRE-7272
design-doc in: docs/app-sre/design-docs/aws-ami-cleanup.md
schema change: app-sre/qontract-schemas#446