Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Use print from graphql directly instead of from graphql-tag #98

Merged
merged 2 commits into from
Mar 17, 2017

Conversation

xavxyz
Copy link
Contributor

@xavxyz xavxyz commented Mar 16, 2017

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

What's up?

Hey! While updating meteor/apollo to use this package (yay! 🚀), we encountered the warning about deprecation of print from graphql-tag (apollographql/meteor-integration#87).

Following discussions from apollographql/graphql-tag#54 & others PRs/issues related, I've made the change & I've tried it locally: tests pass and it works.

I assumed that graphql should be then in dependencies more than devDependencies, right?

@Urigo Urigo merged commit b0c7108 into apollographql:master Mar 17, 2017
@Urigo
Copy link
Contributor

Urigo commented Mar 17, 2017

Cool, thanks @xavcz

@kachkaev
Copy link

kachkaev commented Apr 8, 2017

Would it be possible to release a new version of subscriptions-transport-ws guys? Both 0.5.4 and 0.5.5-alpha.0 seem to be causing this warning in the console:

Warning - the `printer` exports from `graphql-tag` will be removed in the next major version.
See https://github.com/apollographql/graphql-tag/issues/54 for more information.

@Anthonyzou
Copy link

Yeah if you can release a new version that would be great.

@Urigo
Copy link
Contributor

Urigo commented Apr 12, 2017

@Anthonyzou just released 0.5.5. sorry for the delay

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants