Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Adds request interface to match apollo 2.0 #242

Merged
merged 2 commits into from
Jul 31, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Jul 30, 2017

This PR adds support for Apollo's ObservableNetworkInterface.
once Apollo version 2.0 is out, we should add integration with apollo-link,
however now it will be easier as the main function is already implemented.

Closes #201

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@DxCx DxCx changed the title chore(client): add request interface to match apollo 2.0 Adds request interface to match apollo 2.0 Jul 30, 2017
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@DxCx DxCx force-pushed the observable-interface branch from 7a17b9d to 2cbb9c6 Compare July 31, 2017 12:41
@Urigo Urigo merged commit 582a5d6 into apollographql:master Jul 31, 2017
@DxCx DxCx deleted the observable-interface branch July 31, 2017 13:40
baconz pushed a commit to PhiloInc/subscriptions-transport-ws that referenced this pull request Apr 24, 2018
updated README to show versions of dependencies required for graphql-server-koa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants