Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rover-client): introspection result should omit Float scalar #988

Merged
merged 1 commit into from
Feb 9, 2022
Merged

fix(rover-client): introspection result should omit Float scalar #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/rover-client/src/operations/graph/introspect/fixtures/interfaces.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,11 @@
}
},
"isDeprecated": true,
"deprecationReason": "The `reviews` field on product is deprecated to roll over the return\ntype from a simple list to a paginated list. The easiest way to fix your\noperations is to alias the new field `reviewList` to `review`:\n\n {\n ... on Product {\n reviews: reviewList {\n edges {\n review {\n body\n }\n }\n }\n }\n }\n\nOnce all clients have updated, we will roll over this field and deprecate\n`reviewList` in favor of the field name `reviews` again"
"deprecationReason": "The `reviews` field on product is deprecated to roll over the return\ntype from a simple list to a paginated list. The easiest way to fix your\noperations is to alias the new field `reviewList` to `review`.\nOnce all clients have updated, we will roll over this field and deprecate\n`reviewList` in favor of the field name `reviews` again"
},
{
"name": "reviewList",
"description": "A paginated list of reviews. This field naming is temporary while all clients\nmigrate off of the un-paginated version of this field call reviews. To ease this migration,\nalias your usage of `reviewList` to `reviews` so that after the roll over is finished, you\ncan remove the alias and use the final field name:\n\n {\n ... on Product {\n reviews: reviewList {\n edges {\n review {\n body\n }\n }\n }\n }\n }",
"description": "A paginated list of reviews. This field naming is temporary while all clients\nmigrate off of the un-paginated version of this field call reviews. To ease this migration,\nalias your usage of `reviewList` to `reviews` so that after the roll over is finished, you\ncan remove the alias and use the final field name.",
"args": [
{
"name": "first",
Expand Down
34 changes: 4 additions & 30 deletions crates/rover-client/src/operations/graph/introspect/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type SchemaSubscriptionType = graph_introspect_query::GraphIntrospectQuerySchema
type __TypeKind = graph_introspect_query::__TypeKind;

// Represents GraphQL types we will not be encoding to SDL.
const GRAPHQL_NAMED_TYPES: [&str; 12] = [
const GRAPHQL_NAMED_TYPES: [&str; 13] = [
"__Schema",
"__Type",
"__TypeKind",
Expand All @@ -34,6 +34,7 @@ const GRAPHQL_NAMED_TYPES: [&str; 12] = [
"__DirectiveLocation",
"__Directive",
"Boolean",
"Float",
"String",
"Int",
"ID",
Expand Down Expand Up @@ -577,8 +578,6 @@ mod tests {
"The ID of an object"
id: ID!
}
"The `Float` scalar type represents signed double-precision fractional values as specified by [IEEE 754](https://en.wikipedia.org/wiki/IEEE_floating_point)."
scalar Float
"""
A large mass, planet or planetoid in the Star Wars Universe, at the time of
0 ABY.
Expand Down Expand Up @@ -1409,20 +1408,7 @@ mod tests {
"""
The `reviews` field on product is deprecated to roll over the return
type from a simple list to a paginated list. The easiest way to fix your
operations is to alias the new field `reviewList` to `review`:

{
... on Product {
reviews: reviewList {
edges {
review {
body
}
}
}
}
}

operations is to alias the new field `reviewList` to `review`.
Once all clients have updated, we will roll over this field and deprecate
`reviewList` in favor of the field name `reviews` again
"""
Expand All @@ -1431,19 +1417,7 @@ mod tests {
A paginated list of reviews. This field naming is temporary while all clients
migrate off of the un-paginated version of this field call reviews. To ease this migration,
alias your usage of `reviewList` to `reviews` so that after the roll over is finished, you
can remove the alias and use the final field name:

{
... on Product {
reviews: reviewList {
edges {
review {
body
}
}
}
}
}
can remove the alias and use the final field name.
"""
reviewList(first: Int = 5, after: Int = 0): ReviewConnection
}
Expand Down