fix: build with versioned schemas #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit removes the usage of `APOLLO_GRAPHQL_SCHEMA_URL` by `cargo xtask dist --version` since it just didn't work. now, all versions are built by downloading their schema from the GitHub repository if the first build fails. additionally, schemas are now built and versioned with the `cargo xtask package --copy-schema` command, which is now executed properly in CircleCI.
EverlastingBugstopper
force-pushed
the
avery/fixup-schema-build
branch
from
80a7a3e to
839c60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #967
this commit removes the usage of
APOLLO_GRAPHQL_SCHEMA_URLbycargo xtask dist --versionsince it just didn't work.now, all versions are built by downloading their schema from the GitHub
repository if the first build fails.
additionally, schemas are now built and versioned with the
cargo xtask package --copy-schemacommand, which is now executed properly in CircleCI, meaning future releases should include the schema as part of the build process, and running
cargo xtask dist --versionshould work for future releases.