Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic on git remotes w/no apparent owner #731

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

fixes #670 by catching the panic that can occur while using git-url-parse-rs and just returning None.

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/dont-panic-on-invalid-remotes branch from a95f998 to e8602ef Compare August 16, 2021 16:11
@EverlastingBugstopper EverlastingBugstopper merged commit 5a33067 into main Aug 16, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/dont-panic-on-invalid-remotes branch August 16, 2021 19:10
@abernix abernix removed the 2021-08 label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: crashed while running rover subgraph introspect
2 participants