-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds origin to config whoami command #307
Conversation
6733ec9
to
b4d285f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to bring in Houston in like this, as it's essentially used for specificity.
I am not entirely sure about the showing the physical path, which you pointed out in your description, because I feel like users may not know what to do with that information? Since they are usually adding keys with the profile
command, I am wondering if we can very specific with:
Profile: default
or
Profile: work_dev
Yeah I think using the profile name is better here - I'll push an update. |
`rover config whoami` now shows the user the file path that their credentials are stored in, OR if Rover is reading their credentials from the $APOLLO_KEY environment variable
b4d285f
to
d717552
Compare
How do we feel about
instead of |
I like that better. Since we reference profiles the same way everywhere, that seems very reasonable as a hint on how to change it. I think it feels a little weird for the default, but I could handle that |
@lrlna I merged this but if you're strongly opposed to the |
Ohh that looks good to me! Not opposed at all. |
fixes #273
rover config whoami
now shows the user the profile that their credentials are stored in, OR if Rover is reading their credentials from the$APOLLO_KEY
environment variable.output:
i am a tad worried that adding
houston
as a dep torover-client
is a bad design decision, but I thought long and hard about how else we could do this and I came up empty handed. If anybody has any suggestions on how to maybe decouple those (or if you think it's fine) I'm all ears!Also, do we think exposing the actual file location is good here? Or do we think we should just say the name of the profile itself? I'd imagine it'd be useful to know the file location, but also showing it like this might give folks the wrong idea. We'd much rather them interact with this stuff through ourconfig
subcommand suite, so maybe we shouldn't lift the curtains on that abstraction.after this i think i'm gonna try to lump in
rover config show
withwhoami
!