hides api key from debug logs #244
Merged
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeDawkins
requested review from
EverlastingBugstopper and
lrlna
as code owners
lrlna
approved these changes
Feb 8, 2021
EverlastingBugstopper
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
.configfile's contents safely. This would be a little more complicated to safely handle, so for now, I swapped out printing the contents themselves for just printing the data length of the file.Idk if there's a "safe" way to allow actual printing of these (or trace) logs without accidentally printing api keys. It'd be useful for them to be printed somewhere, but I'd want to make it as hard as possible to accidentally miss it and paste it somewhere.
Other ideas
sensitive_tracewould be really cool I think, but that seems to be a more extreme step. Happy to hear any other thoughts or ideas here :)