ROVER-331 Add specific CompositionError handling #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: d990ab3e22e85fda612753e3 |
jonathanrainer
force-pushed
the
jr/bug/ROVER-331
branch
from
0307580 to
5c8b3f3
Compare
monkpow
approved these changes
Feb 25, 2025
It seems that in the move from old to new we got rid of some specific handling around composition errors. This has been re-added
jonathanrainer
force-pushed
the
jr/bug/ROVER-331
branch
from
5c8b3f3 to
6e94efb
Compare
Merged
pubmodmatt
added a commit
that referenced
this pull request
Mar 12, 2025
# [0.28.0] - 2025-03-12 ## 🚀 Features - **Default to Apollo Router 2.x for `rover dev` - @pubmodmatt PR #2433** The default version of Apollo Router used by `rover dev` is now 2.x instead of 1.x. The default can be overridden by setting `APOLLO_ROVER_DEV_ROUTER_VERSION`, for example `APOLLO_ROVER_DEV_ROUTER_VERSION=1.61.0`. - **Implement supergraph config schema command - @jonathanrainer PR #2418** Adds a new `rover supergraph config schema` command to output the JSONSchema for `supergraph.yaml`. This can be used to configure editor support for the file. ## 🐛 Fixes - **Add specific CompositionError handling - @jonathanrainer PR #2422** - **Pass log_level through to Router binary - @monkpow PR #2426** - **Fix formatting of table output by `rover config whoami` - @pubmodmatt PR #2413** - **Better error on missing environment variable - @pubmodmatt PR #2442** ## 🛠 Maintenance - **Add Apollo Router 2.x dependency to renovate - @pubmodmatt PR #2430** - **Fix CI post update to Rustup 1.28 - @jonathanrainer PR #2431** - **Replace backoff with backon - @pubmodmatt PR #2437** - **Add exemption for unmaintained humantime dependency - @pubmodmatt PR #2440** ## 📚 Documentation - **Add docs on using the native GitHub actions - @lleadbet PR #2419** - **Add changelog entry for new behaviour w.r.t subgraph_url - @jonathanrainer PR #2420** - **GitHub CI/CD - @shorgi PR #2427**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2421
It seems that in the move from old to new we got rid of some specific handling around composition errors. This has been re-added
Error From Rover v0.26.3
{"data":{"success":false},"error":{"code":"E029","details":{"build_errors":[{"code":"INVALID_GRAPHQL","message":"[object Object]","nodes":[{"end":null,"source":"@key(\"randomStuff\")\ntype Query {\n field1: String!\n}","start":null,"subgraph":"fed-service-1"}],"omittedNodesCount":0,"type":"composition"}]},"message":"Encountered 1 build error while trying to build a supergraph."},"json_version":"1"}Error from Rover v0.27.2
{"json_version":"1","data":{"success":false},"error":{"message":"Encountered 1 build error while trying to build a supergraph.","code":null}}Error from this PR
{"json_version":"1","data":{"success":false},"error":{"details":{"build_errors":[{"message":"[object Object]","code":"INVALID_GRAPHQL","type":"composition","nodes":[{"subgraph":"fed-service-1","source":"@key(\"randomStuff\")\ntype Query {\n field1: String!\n}","start":null,"end":null}],"omittedNodesCount":0}]},"code":"E029","message":"Encountered 1 build error while trying to build a supergraph."}}