Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scaffold for rover dev rewrite #2228

Merged
merged 6 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ default = ["composition-js"]
# notably, it is disabled for x86_64-unknown-linux-musl builds
# because of this GitHub issue: https://github.com/denoland/deno/issues/3711
composition-js = []
dev-two = []

### cross-workspace dependencies
# these dependencies can be used by any other workspace crate by specifying the dependency like so:
Expand Down
13 changes: 13 additions & 0 deletions src/command/dev/dev_two/do_dev.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
use camino::Utf8PathBuf;

use crate::{command::Dev, utils::client::StudioClientConfig, RoverOutput, RoverResult};

impl Dev {
pub async fn run(

Check failure on line 6 in src/command/dev/dev_two/do_dev.rs

View workflow job for this annotation

GitHub Actions / Build Rover for macOS x86-64

duplicate definitions with name `run`
&self,
override_install_path: Option<Utf8PathBuf>,

Check warning on line 8 in src/command/dev/dev_two/do_dev.rs

View workflow job for this annotation

GitHub Actions / Build Rover for macOS x86-64

unused variable: `override_install_path`
client_config: StudioClientConfig,

Check warning on line 9 in src/command/dev/dev_two/do_dev.rs

View workflow job for this annotation

GitHub Actions / Build Rover for macOS x86-64

unused variable: `client_config`
) -> RoverResult<RoverOutput> {
todo!()
}
}
1 change: 1 addition & 0 deletions src/command/dev/dev_two/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pub mod do_dev;
1 change: 1 addition & 0 deletions src/command/dev/do_dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ pub fn log_err_and_continue(err: RoverError) -> RoverError {
}

impl Dev {
#[cfg(not(feature = "dev-two"))]
pub async fn run(
&self,
override_install_path: Option<Utf8PathBuf>,
Expand Down
3 changes: 3 additions & 0 deletions src/command/dev/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
#[cfg(feature = "composition-js")]
mod compose;

#[cfg(feature = "dev-two", feature = "composition-js")]

Check failure on line 17 in src/command/dev/mod.rs

View workflow job for this annotation

GitHub Actions / Build Rover for macOS x86-64

multiple `cfg` predicates are specified
mod dev_two;

#[cfg(feature = "composition-js")]
mod do_dev;

Expand Down
Loading