Houston, we have some suggestions #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
feature 🎉
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
e5bc1ab to
2444a68
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
d8f8dad to
80fb973
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
2 times, most recently
from
2406990 to
540ab20
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
80fb973 to
ec917e8
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
5 times, most recently
from
57bbfea to
d001533
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
4 times, most recently
from
4e0e626 to
4ef3dd2
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
4ef3dd2 to
4addcb3
Compare
lrlna
requested changes
Jan 27, 2021
There was a problem hiding this comment.
If the mountain will not come to Mohammed, then Mohammed must go to the mountain
In regards to the env problem: what if instead of moving env to its own crate, we move rover-error to rover? I don't see us publishing either of these as crates in the near future, as I see them as application level code. But if something changes, we can always reconsider and factor both env and rover-error out.
What do you think?
lrlna
reviewed
Jan 27, 2021
lrlna
reviewed
Jan 27, 2021
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
2 times, most recently
from
9b387ba to
7bf1b34
Compare
|
yup, that makes sense to me. i've updated #186 to make |
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
4addcb3 to
360d94c
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
7bf1b34 to
8d26826
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
8d26826 to
4bc971d
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
4 times, most recently
from
9b44db7 to
cc10817
Compare
|
Mohammed has gone to the mountain |
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
4bc971d to
c426244
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
2 times, most recently
from
ea84677 to
5e32d77
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
c426244 to
3ecdae8
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
5e32d77 to
9a2dc6c
Compare
EverlastingBugstopper
force-pushed
the
avery/errorerrorerrorerror
branch
from
3ecdae8 to
6fbd736
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
9a2dc6c to
728881d
Compare
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
728881d to
3ec9919
Compare
|
Alright - this is ready for re-review. I've addressed the requested changes but before merging this, I'd like an explicit approval from @lrlna given they marked this as "Changes Requested" 😄 |
EverlastingBugstopper
force-pushed
the
avery/houston-we-have-some-suggestions
branch
from
3ec9919 to
0995efc
Compare
EverlastingBugstopper
deleted the
avery/houston-we-have-some-suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR builds off of the foundation in #186 and adds some suggestions for
HoustonProblem.