Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename --service-name to --name everywhere #201

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

JakeDawkins
Copy link
Contributor

No description provided.

@JakeDawkins JakeDawkins force-pushed the jake/rename-service-name branch from 3bbe95f to d71b887 Compare January 25, 2021 23:37
@JakeDawkins
Copy link
Contributor Author

I included changes to the doc comments and --help texts as well here. Since studio will be changing tab names to mention subgraphs too, I also changed the docs to refer to them as subgraphs :)

@JakeDawkins JakeDawkins added feature 🎉 new commands, flags, functionality, and improved error messages status - needs review labels Jan 26, 2021
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care of this!

@lrlna lrlna merged commit 4af6fb5 into main Jan 27, 2021
@lrlna lrlna deleted the jake/rename-service-name branch January 27, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants