Application level error consumption and handling

Cargo.toml

@@ -16,8 +16,9 @@ robot-panic = { path = "./crates/robot-panic" }
 binstall = { path = "./installers/binstall" }
 
 # crates.io deps
-anyhow = "1.0.36"
+anyhow = "1.0.38"
 atty = "0.2.14"
+ansi_term = "0.12.1"
 console = "0.14.0"
 heck = "0.3.2"
 prettytable-rs = "0.8.0"

src/bin/rover.rs

@@ -1,20 +1,29 @@
-use anyhow::Result;
+use command::RoverStdout;
 use robot_panic::setup_panic;
 use rover::*;
 use sputnik::Session;
 use structopt::StructOpt;
 
-use std::thread;
+use std::{process, thread};
 
-fn main() -> Result<()> {
+fn main() {
     setup_panic!();
+    if let Err(error) = run() {
+        tracing::debug!(?error);
+        eprintln!("{}", error);
+        process::exit(1)
+    } else {
+        process::exit(0)
+    }
+}
 
+fn run() -> Result<()> {
     let app = cli::Rover::from_args();
     timber::init(app.log_level);
     tracing::trace!(command_structure = ?app);
 
     // attempt to create a new `Session` to capture anonymous usage data
-    let result = match Session::new(&app) {
+    let output: RoverStdout = match Session::new(&app) {
         // if successful, report the usage data in the background
         Ok(session) => {
             // kicks off the reporting on a background thread
@@ -45,6 +54,6 @@ fn main() -> Result<()> {
         Err(_) => app.run(),
     }?;
 
-    result.print();
+    output.print();
     Ok(())
 }

src/cli.rs

@@ -1,9 +1,9 @@
-use anyhow::Result;
 use serde::Serialize;
 use structopt::StructOpt;
 
 use crate::env::{RoverEnv, RoverEnvKey};
 use crate::stringify::from_display;
+use crate::Result;
 use crate::{
     client::StudioClientConfig,
     command::{self, RoverStdout},

src/client.rs

@@ -1,4 +1,5 @@
-use anyhow::Result;
+use crate::Result;
+
 use houston as config;
 use rover_client::blocking::StudioClient;
 

src/command/config/auth.rs

@@ -1,4 +1,3 @@
-use anyhow::{Context, Error, Result};
 use console::{self, style};
 use serde::Serialize;
 use structopt::StructOpt;
@@ -7,6 +6,7 @@ use config::Profile;
 use houston as config;
 
 use crate::command::RoverStdout;
+use crate::{anyhow, Context, Result};
 
 #[derive(Debug, Serialize, StructOpt)]
 /// Authenticate a configuration profile with an API key
@@ -27,7 +27,7 @@ pub struct Auth {
 
 impl Auth {
     pub fn run(&self, config: config::Config) -> Result<RoverStdout> {
-        let api_key = api_key_prompt().context("Failed to read API key from terminal")?;
+        let api_key = api_key_prompt()?;
         Profile::set_api_key(&self.profile_name, &config, &api_key)
             .context("Failed while saving API key")?;
         Profile::get_api_key(&self.profile_name, &config)
@@ -50,7 +50,7 @@ fn api_key_prompt() -> Result<String> {
     if is_valid(&api_key) {
         Ok(api_key)
     } else {
-        Err(Error::msg("Received an empty API Key. Please try again."))
+        Err(anyhow!("Received an empty API Key. Please try again.").into())
     }
 }
 

src/command/config/clear.rs

@@ -1,8 +1,8 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
 use crate::command::RoverStdout;
+use crate::{Context, Result};
 
 use houston as config;
 

src/command/config/delete.rs

@@ -1,10 +1,10 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
 use houston as config;
 
 use crate::command::RoverStdout;
+use crate::{Context, Result};
 
 #[derive(Debug, Serialize, StructOpt)]
 /// Delete a configuration profile

src/command/config/list.rs

@@ -1,7 +1,7 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
+use crate::{Context, Result};
 use houston as config;
 
 use crate::command::RoverStdout;

src/command/config/mod.rs

@@ -4,13 +4,13 @@ mod delete;
 mod list;
 mod show;
 
-use anyhow::Result;
 use serde::Serialize;
 use structopt::StructOpt;
 
 use houston as config;
 
 use crate::command::RoverStdout;
+use crate::Result;
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Config {

src/command/config/show.rs

@@ -1,10 +1,10 @@
-use anyhow::Result;
 use serde::Serialize;
 use structopt::StructOpt;
 
 use houston as config;
 
 use crate::command::RoverStdout;
+use crate::Result;
 #[derive(Debug, Serialize, StructOpt)]
 /// View a configuration profile's details
 ///
@@ -24,15 +24,7 @@ impl Show {
             sensitive: self.sensitive,
         };
 
-        let profile = config::Profile::load(&self.name, &config, opts).map_err(|e| {
-            let context = match e {
-            config::HoustonProblem::NoNonSensitiveConfigFound(_) => {
-                "Could not show any profile information. Try re-running with the `--sensitive` flag"
-            }
-            _ => "Could not load profile",
-        };
-            anyhow::anyhow!(e).context(context)
-        })?;
+        let profile = config::Profile::load(&self.name, &config, opts)?;
 
         tracing::info!("{}: {}", &self.name, profile);
         Ok(RoverStdout::None)

src/command/graph/check.rs

@@ -1,4 +1,3 @@
-use anyhow::{Context, Result};
 use prettytable::{cell, row, Table};
 use serde::Serialize;
 use structopt::StructOpt;
@@ -9,6 +8,7 @@ use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::utils::loaders::load_schema_from_flag;
 use crate::utils::parsers::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};
+use crate::{Context, Result};
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Check {
@@ -68,8 +68,8 @@ impl Check {
 
         match num_failures {
             0 => Ok(RoverStdout::None),
-            1 => Err(anyhow::anyhow!("Encountered 1 failure.")),
-            _ => Err(anyhow::anyhow!("Encountered {} failures.", num_failures)),
+            1 => Err(anyhow::anyhow!("Encountered 1 failure.").into()),
+            _ => Err(anyhow::anyhow!("Encountered {} failures.", num_failures).into()),
         }
     }
 }

src/command/graph/fetch.rs

@@ -1,4 +1,3 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
@@ -7,6 +6,7 @@ use rover_client::query::graph::fetch;
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::utils::parsers::{parse_graph_ref, GraphRef};
+use crate::Result;
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Fetch {
@@ -39,8 +39,7 @@ impl Fetch {
                 variant: Some(self.graph.variant.clone()),
             },
             &client,
-        )
-        .context("Failed while fetching from Apollo Studio")?;
+        )?;
 
         Ok(RoverStdout::SDL(sdl))
     }

src/command/graph/mod.rs

@@ -2,12 +2,12 @@ mod check;
 mod fetch;
 mod push;
 
-use anyhow::Result;
 use serde::Serialize;
 use structopt::StructOpt;
 
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
+use crate::Result;
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Graph {

src/command/graph/push.rs

@@ -1,4 +1,3 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
@@ -8,6 +7,7 @@ use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::utils::loaders::load_schema_from_flag;
 use crate::utils::parsers::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};
+use crate::{Context, Result};
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Push {

src/command/install/mod.rs

@@ -1,10 +1,10 @@
-use anyhow::{anyhow, Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
 use binstall::Installer;
 
 use crate::command::RoverStdout;
+use crate::{anyhow, Context, Result};
 
 use std::env;
 use std::path::PathBuf;
@@ -36,7 +36,7 @@ impl Install {
             }
             Ok(RoverStdout::None)
         } else {
-            Err(anyhow!("Failed to get the current executable's path."))
+            Err(anyhow!("Failed to get the current executable's path.").into())
         }
     }
 }

src/command/subgraph/check.rs

@@ -1,8 +1,8 @@
-use anyhow::{Context, Result};
 use prettytable::{cell, row, Table};
 use serde::Serialize;
 use structopt::StructOpt;
 
+use crate::{Context, Result};
 use rover_client::query::subgraph::check;
 
 use crate::client::StudioClientConfig;
@@ -113,13 +113,12 @@ fn handle_checks(check_result: check::CheckResult) -> Result<RoverStdout> {
 
     match num_failures {
         0 => Ok(RoverStdout::None),
-        1 => Err(anyhow::anyhow!(
-            "Encountered 1 failure while checking your subgraph."
-        )),
+        1 => Err(anyhow::anyhow!("Encountered 1 failure while checking your subgraph.").into()),
         _ => Err(anyhow::anyhow!(
             "Encountered {} failures while checking your subgraph.",
             num_failures
-        )),
+        )
+        .into()),
     }
 }
 
@@ -133,12 +132,13 @@ fn handle_composition_errors(
     }
     match num_failures {
         0 => Ok(RoverStdout::None),
-        1 => Err(anyhow::anyhow!(
-            "Encountered 1 composition error while composing the subgraph."
-        )),
+        1 => Err(
+            anyhow::anyhow!("Encountered 1 composition error while composing the subgraph.").into(),
+        ),
         _ => Err(anyhow::anyhow!(
             "Encountered {} composition errors while composing the subgraph.",
             num_failures
-        )),
+        )
+        .into()),
     }
 }

src/command/subgraph/delete.rs

@@ -1,8 +1,10 @@
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::utils::parsers::{parse_graph_ref, GraphRef};
-use anyhow::Result;
+use crate::Result;
+
 use rover_client::query::subgraph::delete::{self, DeleteServiceResponse};
+
 use serde::Serialize;
 use structopt::StructOpt;
 

src/command/subgraph/fetch.rs

@@ -1,4 +1,3 @@
-use anyhow::{Context, Result};
 use serde::Serialize;
 use structopt::StructOpt;
 
@@ -7,6 +6,7 @@ use rover_client::query::subgraph::fetch;
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
 use crate::utils::parsers::{parse_graph_ref, GraphRef};
+use crate::{Context, Result};
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Fetch {

src/command/subgraph/mod.rs

@@ -3,12 +3,12 @@ mod delete;
 mod fetch;
 mod push;
 
-use anyhow::Result;
 use serde::Serialize;
 use structopt::StructOpt;
 
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
+use crate::Result;
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Subgraph {

src/command/subgraph/push.rs

@@ -1,13 +1,13 @@
-use anyhow::{Context, Result};
-use rover_client::query::subgraph::push::{self, PushPartialSchemaResponse};
 use serde::Serialize;
 use structopt::StructOpt;
 
 use crate::client::StudioClientConfig;
 use crate::command::RoverStdout;
-
 use crate::utils::loaders::load_schema_from_flag;
 use crate::utils::parsers::{parse_graph_ref, parse_schema_source, GraphRef, SchemaSource};
+use crate::{Context, Result};
+
+use rover_client::query::subgraph::push::{self, PushPartialSchemaResponse};
 
 #[derive(Debug, Serialize, StructOpt)]
 pub struct Push {

src/error/metadata/code.rs

@@ -0,0 +1,10 @@
+use std::fmt::{self, Display};
+
+#[derive(Debug)]
+pub enum Code {}
+
+impl Display for Code {
+    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(formatter, "{:?}", &self)
+    }
+}