-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rover Docs Rough Pass #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!!!
i do think it may be worth splitting this up into a couple of smaller bite size PRs just so they are easier to review and also so that we can merge stuff that's done without blocking on stuff that's still WIP |
Or perhaps given we are pre-release you can merge the mega and make edits as smaller bits? |
that also works |
Yeah, I asked Stephen how he'd like to get a PR formatted for a first pass, and he preferred a single large PR so he could make structural changes if needed. I have no problems with merging early and iterating though once we get to that point @EverlastingBugstopper! We'd just need to unlink the issues to make sure we don't bulk close them all before a final polish |
I'm fine with this getting merged and opening PRs against main! Probably easiest for everyone. Mostly want to make sure people don't have big additions or edits to make before potentially shuffling content around |
- Add essential concepts - Add working with subgraphs template - Update gatsby config to include all pages
5a62685
to
ad02110
Compare
- change other incorrect shortlinks
Co-authored-by: Stephen Barlow <[email protected]>
This PR is just a mega-PR for all the release docs work