Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover Docs Rough Pass #160

Merged
merged 17 commits into from
Jan 12, 2021
Merged

Rover Docs Rough Pass #160

merged 17 commits into from
Jan 12, 2021

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Jan 4, 2021

This PR is just a mega-PR for all the release docs work

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!!!

@EverlastingBugstopper
Copy link
Contributor

This PR is just a mega-PR for all the release docs work

i do think it may be worth splitting this up into a couple of smaller bite size PRs just so they are easier to review and also so that we can merge stuff that's done without blocking on stuff that's still WIP

@ndintenfass
Copy link
Contributor

Or perhaps given we are pre-release you can merge the mega and make edits as smaller bits?

@EverlastingBugstopper
Copy link
Contributor

that also works

@JakeDawkins
Copy link
Contributor Author

JakeDawkins commented Jan 11, 2021

This PR is just a mega-PR for all the release docs work

i do think it may be worth splitting this up into a couple of smaller bite size PRs just so they are easier to review and also so that we can merge stuff that's done without blocking on stuff that's still WIP

Yeah, I asked Stephen how he'd like to get a PR formatted for a first pass, and he preferred a single large PR so he could make structural changes if needed. I have no problems with merging early and iterating though once we get to that point @EverlastingBugstopper!

We'd just need to unlink the issues to make sure we don't bulk close them all before a final polish

@StephenBarlow
Copy link
Contributor

I'm fine with this getting merged and opening PRs against main! Probably easiest for everyone. Mostly want to make sure people don't have big additions or edits to make before potentially shuffling content around

@JakeDawkins JakeDawkins changed the title [WIP] Rover Docs Rover Docs Rough Pass Jan 12, 2021
@JakeDawkins JakeDawkins merged commit dec438c into main Jan 12, 2021
@JakeDawkins JakeDawkins deleted the jake/docs branch January 12, 2021 20:07
lrlna pushed a commit that referenced this pull request Jan 28, 2021
Co-authored-by: Stephen Barlow <[email protected]>
@JakeDawkins JakeDawkins mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📝 improvements or additions to docs on the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants