Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't squash supergraph router config (#1536 #1536

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

EverlastingBugstopper
Copy link
Contributor

This PR fixes the router configuration squashing issue defined in #1535.

@EverlastingBugstopper EverlastingBugstopper self-assigned this Mar 7, 2023
@EverlastingBugstopper EverlastingBugstopper added this to the vNext milestone Mar 7, 2023
@EverlastingBugstopper EverlastingBugstopper added the fix 🩹 fixes a bug label Mar 7, 2023
Copy link

@westhechiang westhechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/no-squash-router-config branch from 82e6580 to bd0ba64 Compare March 8, 2023 16:44
@EverlastingBugstopper EverlastingBugstopper changed the title fix: don't squash supergraph router config fix: don't squash supergraph router config (#1536 Mar 9, 2023
@EverlastingBugstopper EverlastingBugstopper merged commit b09648e into main Mar 9, 2023
@EverlastingBugstopper EverlastingBugstopper deleted the avery/no-squash-router-config branch March 9, 2023 22:24
EverlastingBugstopper pushed a commit that referenced this pull request Mar 10, 2023
…oreply.github.com>

# [0.13.0] - 2023-03-10

## 🚀 Features

- **Dynamic templates - @dbanty, #1388**

Rover now fetches templates from a GraphQL API. New templates can be
contributed to [the templates
repo](https://github.com/apollographql/templates) and will not require a
new release of Rover to be used. To see the latest templates, run `rover
template list`.

## 🐛 Fixes

- **Fixes behavior of `--router-config` in `rover dev` -
@EverlastingBugstopper, #1536 fixes #1535**

Older versions of Rover did not respect the `supergraph` section of the
`--router-config` file. This has been fixed in v0.13.0.

---------

Co-authored-by: Dylan Anthony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants