fix: allow checks to fail from composition (#1525 #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/fix-checks
branch
from
57b1496 to
5891ae0
Compare
jsegaran
approved these changes
Feb 23, 2023
EverlastingBugstopper
force-pushed
the
avery/fix-checks
branch
from
5891ae0 to
5d582d9
Compare
EverlastingBugstopper
force-pushed
the
avery/fix-checks
branch
from
5d582d9 to
7fb19ee
Compare
EverlastingBugstopper
changed the title
EverlastingBugstopper
added a commit
that referenced
this pull request
Feb 23, 2023
# [0.12.2] - 2023-02-23 ## 🚀 Features - **Warn when `federation_version` is not pinned - @EverlastingBugstopper, #1524** As of this release, we no longer recommend auto-updates for the `rover supergraph compose` command because of the coordination path that is required to roll out new versions of Federation. If you do not specify an exact `federation_version`, a warning will be printed. In a future version of Rover we will entirely deprecate auto-updating, so please migrate now. This change includes some changes to our documentation as well, check out [the docs](https://www.apollographql.com/docs/rover/commands/supergraphs/#setting-a-composition-version) for more information. ## 🐛 Fixes - **Fixes composition error reporting in `rover subgraph check` - @EverlastingBugstopper, #1525** In Rover v0.12.0 and v0.12.1, running a `rover subgraph check` with an invalid schema failed to report the composition errors, this behavior is fixed in v0.12.2. ## 🛠 Maintenance - **Updates internal node dependencies - @EverlastingBugstoppe** `node` v18.14.0 -> v18.14.1 `npm` v9.4.2 -> v9.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of 0.12.0, running
rover subgraph checkwith a schema that fails to compose results in an inscrutable error message:Operation check task has no result.This PR fixes that by returning composition errors before checking operation check tasks. It also updates the
Operation check task has no resulterror message to be a malformed response error type, which shouldn't occur in practice.