fix: Error if the check workflow fails but all known tasks succeed #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
requested review from
EverlastingBugstopper and
lrlna
as code owners
|
note from our call: let's update the error message to say "Composition checks and operation checks succeeded, but other check tasks failed." and leave the suggestion pretty much exactly how it is. |
sachindshinde
force-pushed
the
sachin/fix-unknown-check-error
branch
from
cdcbf5c to
0cfde96
Compare
…kflow fails but the tasks it knows about have succeeded
sachindshinde
force-pushed
the
sachin/fix-unknown-check-error
branch
from
0cfde96 to
1829cda
Compare
Would request two slight wording changes if they look fine:
|
EverlastingBugstopper
approved these changes
Sep 1, 2022
| ChangeSeverity::FAIL => Err(RoverClientError::OtherCheckTaskFailure { | ||
| has_build_task, | ||
| target_url: check_response.target_url.unwrap_or_else(|| | ||
| // Note that graph IDs and variants don't need percent-encoding due to their regex restrictions. |
There was a problem hiding this comment.
you love to see it
Co-authored-by: Avery Harnish <[email protected]>
EverlastingBugstopper
added
the
feature 🎉
Merged
EverlastingBugstopper
added a commit
that referenced
this pull request
Sep 6, 2022
# [0.8.2] - 2022-09-06 ## 🚀 Features - **Check commands exit with failure when downstream tasks fail - @sachindshinde, #1280** Historically, `rover graph check` and `rover subgraph check` have aggregated errors for operation checks and/or composition checks. Checks are expanding in Studio and will continue to expand over time, starting with downstream contract checks for `rover subgraph check`. When these tasks fail, Rover will throw an error and link to the checks page in Studio which will contiain more information on the exact failure. - **Detect improper VS Code API key pastes on Windows - @EverlastingBugstopper, #1026, 1268** We have added new error messages and recovery suggestions for malformed API keys caused by invalid copy+pastes in VS Code on Windows. - **Adds `--watch` to `introspect` commands - @EverlastingBugstopper, #1207** If you pass the `--watch` flag to `rover graph introspect` or `rover subgraph introspect`, the GraphQL server will be introspected once every second, printing updates to the terminal as the introspection response changes. This could be used to bootstrap development workflows when combined with `--output json` and a tool like `jq`. ## 🐛 Fixes - **Trim double quotes in multilingual descriptions - @lrlna, #1245 fixes #1244 and #1114** `rover graph introspect` no longer crashes if a field description contains cyrillic symbols. - **Fix link to ELv2 license information - @EverlastingBugstopper, #1262 fixes #1261** ## 🛠 Maintenance - **Link directly to API Keys page in Studio - @abernix, #1202** The `rover config auth` command will now provide a link that takes you directly to the "API Keys" page where you can create a Personal API Key, rather than a page that requires you to click through to another page. - **Skip Apollo Studio integration tests for fork PRs - @EverlastingBugstopper, #Issue #, 1216** Our CI pipeline skips Apollo Studio integration tests for forked repositories because they don't have access to the Apollo Studio organization that we use to run them. - **Updates MacOS CI pipeline to use xcode 13.4 - @EverlastingBugstopper, #1211** - **Normalize git remote URLs for anonymized telemetry - @EverlastingBugstopper, #1279**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rover currently only fails a check if the tasks it knows about haven't errored. This causes issues when Studio introduces new tasks, as old versions of Rover will mistakenly think a check succeeded when it failed.
This PR:
RoverClientError::OtherCheckTaskFailure) and code (E036) to convey when this occurs.CheckResponse::try_new()to return this error when the operations check succeeds, but the check workflow has not.If you'd like to test this out, please ping me on Slack (as the new task that would elicit this error is currently feature-flagged in Studio).