Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documention for the rover readme commands #1141

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

cy
Copy link
Contributor

@cy cy commented Jun 7, 2022

This adds a documentation page for the rover readme fetch and rover readme publish commands

Closes #1140

@cy cy requested a review from StephenBarlow as a code owner June 7, 2022 15:01
@netlify
Copy link

netlify bot commented Jun 7, 2022

👷 Deploy request for apollo-cli-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ad3aea9

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good! just a few small changes 😄

Co-authored-by: Avery Harnish <[email protected]>
@cy cy requested a review from EverlastingBugstopper June 7, 2022 17:58
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! i'll wait for a review from @StephenBarlow before merging

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small URL and wording suggestions!

Co-authored-by: Stephen Barlow <[email protected]>
@cy
Copy link
Contributor Author

cy commented Jun 7, 2022

thank you both - will one of you merge for me because I don't have merge access here. Thanks again :D

@EverlastingBugstopper EverlastingBugstopper merged commit b1f283c into apollographql:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document readme commands
3 participants