chore: use graphql endpoint to fetch schema #1126
Conversation
✅ Deploy Preview for apollo-cli-docs canceled.
|
| }"#; | ||
|
|
||
| fn query(fetch_document: bool) -> Result<(String, Option<String>)> { | ||
| let graphql_endpoint = option_env!("APOLLO_GRAPHQL_SCHEMA_URL") |
There was a problem hiding this comment.
i'm not sure how useful this lever is - perhaps it would be better for us to support an environment variable that changes the variant we're fetching the schema from? not sure! fwiw i'm not sure if anybody is even using this endpoint right now for their build setups - it's not super easy to prototype w/Rover quite yet because of the inflexibility of rust's graphql-client library
There was a problem hiding this comment.
Yea. I think for local dev stuff it would be nice if we could point to a different variant that has our testing or experimental features but it would require some work to make our testing variants public, so probably should scope out from this initial change?
This does set us up nicely to be able to fetch any schema from studio though so eventually devs could test things before they hit the public api.
There was a problem hiding this comment.
👍🏼 cool, i'll leave this as is then and as things progress we can revisit and make this a bit more configurable. thanks a bunch for doing the leg work to make this possible 😄
EverlastingBugstopper
force-pushed
the
avery/use-graphql-endpoint
branch
from
5906488 to
465075e
Compare
This PR updates
rover-client/build.rsto fetch the schema hash instead of the etag. if the hash is different than what is on the local machine, the query will be re-run to fetch the schema and put it at./.schema/schema.graphql.cc @jsegaran