-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: windows installer #104
feat: windows installer #104
Conversation
@jbaxleyiii in the original description i said
you'll need to run the command at the bottom that uses my fork in order for testing end to end to work ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EverlastingBugstopper this looks good to me! Really nice work taking care of this \o/
for now you'll get a panic with the above command since the binary it's downloading does not have the changes to
rover
that are necessary for the windows installer to actually work.
What changes do you still need to land before we can merge this?
As for the version being hardcoded, I think there are a few things we can do (and they can be done after we merge this):
- curl github to get the latest release, here is a script someone wrote in bash that we can rewrite to powershell
- run
npm show rover version
. This does require us to have rover published to npm first, and it does hinge on the user to have npm on their system (so I prefer the first suggestion)
none! it's just that this hasn't been merged + tagged yet, so the changes introduced in this PR have not made it into our release binaries. that's the only reason it'll panic right now. once we merge, tag and build a binary with the changes introduced in this PR, running that command with the as for getting the latest version of the release that script seems like a great way to do this. we will need to figure out how to differentiate between our beta releases and our stable releases though, so it might be good to work that stuff out in a separate issue. |
Sweet! That sounds good. Merge away then 🚀 |
This PR adds a windows installer for Rover. We still need to figure out a way for the version to not be hardcoded but for now the bones are good.
This works very similarly to the Unix installer in that it downloads and extracts a
.tar.gz
and then just runsrover install
which takes care of moving the running binary to a well knownbin
directory and then adding it to the user'sPATH
.once we publish a new
rc
and point to it from within this script, it can be used like soiwr 'https://raw.githubusercontent.com/apollographql/rover/236dadda93edaa910dbeaa92893b7da2c27e4973/installers/binstall/scripts/windows/install.ps1' | iex
for now you'll get a panic with the above command since the binary it's downloading does not have the changes to
rover
that are necessary for the windows installer to actually work.i tested everything on my fork, so if you want to run a command to see if it works well on your machine, you can run this command:
iwr 'https://raw.githubusercontent.com/EverlastingBugstopper/rover/avery/wtf/installers/binstall/scripts/windows/install.ps1' | iex